Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added custom domain support in ga4 #1697

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

manish339k
Copy link
Contributor

@manish339k manish339k commented Apr 19, 2024

PR Description

In this PR, we are adding support in GA4 to take sdkBaseUrl from the config and load the gtag.js with {sdkBaseUrl}/gtag/js?id=${measurementId}. Default value of sdkBaseUrl is https://www.googletagmanager.com .

Linear task (optional)

Resolves INT-1983

Linear task link

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • New Features
    • Enhanced the analytics integration by allowing a customizable base URL for script loading, improving flexibility and control over script sources.

Copy link
Contributor

coderabbitai bot commented Apr 19, 2024

Walkthrough

The Google Analytics 4 (GA4) integration in the analytics library has been updated to include a new sdkBaseUrl property for configuration. This enhancement allows for more flexible script loading by specifying a base URL. The loadScript method now utilizes this parameter, and the init method has been modified to pass the sdkBaseUrl to loadScript.

Changes

File Path Change Summary
.../GA4/browser.js Added sdkBaseUrl to config, updated loadScript to use this parameter
.../GA4/browser.test.js Added SdkBaseUrl to initialization call, improved parameter passing in constructor

Poem

🐇🌟
In the land of code, where the bits frolic free,
A rabbit hopped by, tweaking GA4 with glee.
"A new path to tread, scripts to load with zest,
Let's make this base URL, truly the best!"
With a twinkle in its eye, it danced away,
Leaving trails of code, brightening the day. 🌼🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.93%. Comparing base (ba33b9e) to head (5a68380).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1697   +/-   ##
========================================
  Coverage    53.92%   53.93%           
========================================
  Files          461      461           
  Lines        15615    15616    +1     
  Branches      3108     3090   -18     
========================================
+ Hits          8421     8422    +1     
- Misses        5840     5928   +88     
+ Partials      1354     1266   -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 19, 2024

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.78 KB 15.78 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.66 KB 7.66 KB (0%) 8 KB
Core CJS - NPM 22.47 KB 22.47 KB (0%) 23 KB
Core - NPM 22.56 KB 22.56 KB (0%) 23 KB
Core Legacy - CDN 43 KB 43 KB (0%) 44 KB
Core - CDN 22.71 KB 22.71 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.57 KB 31.57 KB (0%) 32 KB
Core - NPM - v1.1 31.56 KB 31.56 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.4 KB 98.48 KB (+0.08% ▲) 105 KB

@Gauravudia
Copy link
Contributor

Gauravudia commented Apr 19, 2024

@manish339k Add browser testcases

…rowser.js

Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com>
shrouti1507
shrouti1507 previously approved these changes Apr 22, 2024
@manish339k
Copy link
Contributor Author

@manish339k Add browser testcases

done.

Gauravudia
Gauravudia previously approved these changes Apr 22, 2024
@manish339k manish339k dismissed stale reviews from Gauravudia and shrouti1507 via 04cdbd0 April 23, 2024 12:34
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manish339k manish339k merged commit 3543cc1 into develop Apr 24, 2024
8 of 9 checks passed
@manish339k manish339k deleted the feat.ga4_custom_domain_support branch April 24, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants