Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct measurement name and tags for aggregated pending events metrics #1891

Merged
merged 1 commit into from Apr 26, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Apr 26, 2022

Description

Fix, using the correct measurement name and tags for aggregate metrics.

Previously the following measurement was recorded:

jobsdb_ALL_pending_events_count workspace=ALL,destType=<type>

Now:
jobsdb_rt_pending_events_count workspace=ALL,destType=ALL
jobsdb_batch_rt_pending_events_count workspace=ALL,destType=ALL

Notion Ticket

https://www.notion.so/rudderstacks/Use-the-correct-measurement-name-and-tags-for-aggregated-pending-events-metrics-dbfc88275e9e4652ad4067f58c24c214

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1891 (ef6827c) into master (4d0992e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   25.14%   25.11%   -0.03%     
==========================================
  Files         120      120              
  Lines       28961    28961              
==========================================
- Hits         7282     7275       -7     
- Misses      21343    21346       +3     
- Partials      336      340       +4     
Impacted Files Coverage Δ
...ebugger/destination/eventDeliveryStatusUploader.go 90.12% <0.00%> (-3.71%) ⬇️
services/debugger/uploader.go 97.24% <0.00%> (-2.76%) ⬇️
gateway/gateway.go 47.35% <0.00%> (-0.26%) ⬇️
router/router.go 64.67% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0992e...ef6827c. Read the comment docs.

@atzoum atzoum merged commit 5f45c1f into master Apr 26, 2022
@atzoum atzoum deleted the fix.pendingEventsAllMetrics branch April 26, 2022 11:24
This was referenced Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants