Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduced log & stats for retry of jobsDB execute & query methods #2434

Merged
merged 3 commits into from Sep 16, 2022

Conversation

saurav-malani
Copy link
Contributor

Description

Here we have introduced logs & metrics for retry of query & execute methods of jobsDB. This is done by passing notify func while calling RetryWithNotify & QueryWithRetriesAndNotify. notify is called whenever an attempt fails.

Notion Ticket

https://www.notion.so/rudderstacks/Introduce-logs-and-alerts-for-jobsDB-retries-f20f44ddb5a7492a9c99fa49dba5cf3c

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #2434 (a84216c) into master (12d3e59) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2434      +/-   ##
==========================================
- Coverage   36.20%   36.18%   -0.02%     
==========================================
  Files         200      200              
  Lines       39663    39680      +17     
==========================================
  Hits        14360    14360              
- Misses      24399    24418      +19     
+ Partials      904      902       -2     
Impacted Files Coverage Δ
jobsdb/jobsdb.go 68.80% <ø> (+0.29%) ⬆️
router/batchrouter/batchrouter.go 33.63% <17.07%> (-0.17%) ⬇️
services/multitenant/tenantstats.go 83.00% <28.57%> (-0.84%) ⬇️
processor/processor.go 71.26% <38.88%> (-1.16%) ⬇️
router/router.go 67.24% <52.63%> (-0.36%) ⬇️
utils/misc/retry.go 77.77% <93.33%> (+5.68%) ⬆️
config/backend-config/backend-config.go 69.88% <0.00%> (+0.56%) ⬆️
enterprise/reporting/reporting.go 9.82% <0.00%> (+1.44%) ⬆️
config/backend-config/namespace_config.go 78.62% <0.00%> (+2.29%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

utils/misc/retry.go Show resolved Hide resolved
utils/misc/retry.go Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb_test.go Outdated Show resolved Hide resolved
utils/misc/retry.go Show resolved Hide resolved
services/multitenant/tenantstats.go Outdated Show resolved Hide resolved
router/router.go Outdated Show resolved Hide resolved
router/router.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
@chandumlg chandumlg merged commit c1b90f1 into master Sep 16, 2022
@chandumlg chandumlg deleted the chore.jobsDBRetryLogging branch September 16, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants