chore(warehouse): warehouse api to capture task run ID when calculating the pending uploads. #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
+ Coverage 36.15% 36.21% +0.05%
==========================================
Files 200 200
Lines 39644 39676 +32
==========================================
+ Hits 14335 14368 +33
+ Misses 24407 24404 -3
- Partials 902 904 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abhimanyubabbar
changed the title
abhimanyubabbar
force-pushed
the
chore.augment-pending-events
branch
from
e9a18f8
to
b019692
Compare
achettyiitr
requested changes
Sep 14, 2022
achettyiitr
reviewed
Sep 14, 2022
| @@ -1361,6 +1361,11 @@ func pendingEventsHandler(w http.ResponseWriter, r *http.Request) { | |||
| // TODO : respond with errors in a common way | |||
| pkgLogger.LogRequest(r) | |||
|
|
|||
| if r.Method != "POST" { | |||
There was a problem hiding this comment.
Instead of using this can we move this to the server mutex?
mux := mux.NewRouter()
mux.HandleFunc("/v1/warehouse/pending-events", pendingEventsHandler).Methods("POST")
There was a problem hiding this comment.
We would not need this right.
achettyiitr
requested changes
Sep 14, 2022
warehouse/warehouse.go
Outdated
| @@ -1678,7 +1691,7 @@ func startWebHandler(ctx context.Context) error { | |||
| backendconfig.DefaultBackendConfig.WaitForConfig(ctx) | |||
| mux.HandleFunc("/v1/process", processHandler) | |||
| // triggers uploads only when there are pending events and triggerUpload is sent for a sourceId | |||
| mux.HandleFunc("/v1/warehouse/pending-events", pendingEventsHandler) | |||
| mux.HandleFunc("/v1/warehouse/pending-events", pendingEventsHandler).Methods("GET") | |||
There was a problem hiding this comment.
We don't have a Methods function for ServerMux. We would need to convert it to Router.
mux := mux.NewRouter()
mux.HandleFunc("/v1/warehouse/pending-events", pendingEventsHandler).Methods("POST")
| @@ -1361,6 +1361,11 @@ func pendingEventsHandler(w http.ResponseWriter, r *http.Request) { | |||
| // TODO : respond with errors in a common way | |||
| pkgLogger.LogRequest(r) | |||
|
|
|||
| if r.Method != "POST" { | |||
There was a problem hiding this comment.
We would not need this right.
abhimanyubabbar
force-pushed
the
chore.augment-pending-events
branch
from
99077e4
to
8aa37a4
Compare
abhimanyubabbar
force-pushed
the
chore.augment-pending-events
branch
from
8aa37a4
to
7afe7b1
Compare
Jayachand
approved these changes
Sep 15, 2022
achettyiitr
approved these changes
Sep 21, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For sources to know that the task run has no transient uploads in the system, we need to capture the task run id in the endpoint and then call the pendingUploadCount with this filterBy clause.
Notion Ticket
https://www.notion.so/rudderstacks/Warehouse-Pending-Events-API-a3e22ec2834c427fa3a7b8ed02c8e63e
Security