chore: add resource tags in metrics #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 43.93% // Head: 43.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2462 +/- ##
=======================================
Coverage 43.93% 43.94%
=======================================
Files 187 187
Lines 39114 39125 +11
=======================================
+ Hits 17186 17193 +7
- Misses 20840 20846 +6
+ Partials 1088 1086 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lvrach
reviewed
Sep 23, 2022
| @@ -1079,6 +1079,7 @@ func (worker *workerT) sendRouterResponseCountStat(status *jobsdb.JobStatusT, de | |||
| "destType": worker.rt.destName, | |||
| "respStatusCode": status.ErrorCode, | |||
| "destination": destinationTag, | |||
| "destId": destination.ID, | |||
There was a problem hiding this comment.
Similar to my comment here:
#2430 (comment)
As destination is of high granularity, we should exclude it in free multitenant cluster.
satishrudderstack
requested review from
cisse21,
atzoum and
rudder-server-bot
lvrach
approved these changes
Oct 11, 2022
achettyiitr
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add resource tags in metrics