Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only report features on master / standalone warehouse #2483

Merged
merged 2 commits into from Sep 27, 2022

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Sep 26, 2022

Description

Supported features should only be reported by the master or a standalone warehouse setup. Moreover, backend configuration was not initialised for the slave, causing a panic.

Notion Ticket

https://www.notion.so/rudderstacks/only-report-features-on-master-44064ef1dd1d49e59421ffa5545911e7

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 40.24% // Head: 40.24% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (52c25e4) compared to base (74f268c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   40.24%   40.24%   -0.01%     
==========================================
  Files         169      169              
  Lines       35980    35981       +1     
==========================================
  Hits        14481    14481              
- Misses      20587    20588       +1     
  Partials      912      912              
Impacted Files Coverage Δ
warehouse/warehouse.go 3.10% <0.00%> (-0.01%) ⬇️
config/backend-config/namespace_config.go 77.37% <0.00%> (-2.19%) ⬇️
utils/httputil/server.go 92.30% <0.00%> (+11.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvrach lvrach requested review from achettyiitr and a team September 27, 2022 07:16
@lvrach lvrach changed the title Only report features on master / standalone warehouse fix: only report features on master / standalone warehouse Sep 27, 2022
@lvrach lvrach marked this pull request as ready for review September 27, 2022 07:16
@lvrach lvrach merged commit 33ba5ef into master Sep 27, 2022
@lvrach lvrach deleted the fix/features-on-master branch September 27, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants