refactor: stats package #2489
Merged
refactor: stats package #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 40.54% // Head: 41.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
+ Coverage 40.54% 41.36% +0.82%
==========================================
Files 174 175 +1
Lines 36237 36266 +29
==========================================
+ Hits 14691 15003 +312
+ Misses 20627 20326 -301
- Partials 919 937 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
refactor.stats
branch
3 times, most recently
from
ddc8e4f
to
c036621
Compare
atzoum
commented
Sep 27, 2022
atzoum
force-pushed
the
refactor.stats
branch
3 times, most recently
from
d697f80
to
da1426f
Compare
atzoum
force-pushed
the
refactor.stats
branch
from
da1426f
to
65bd41d
Compare
atzoum
force-pushed
the
refactor.stats
branch
from
65bd41d
to
e1d860e
Compare
lvrach
approved these changes
Sep 28, 2022
lvrach
approved these changes
Sep 28, 2022
atzoum
force-pushed
the
refactor.stats
branch
from
e1d860e
to
4f095f6
Compare
atzoum
commented
Sep 29, 2022
chandumlg
reviewed
Sep 29, 2022
chandumlg
reviewed
Sep 29, 2022
atzoum
force-pushed
the
refactor.stats
branch
from
06d8608
to
a8b1ab1
Compare
chandumlg
approved these changes
Sep 29, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the stats package and introducing the following improvements:
stats.Statsinstances (including the default, singleton instance). No more global variables.Stats.Start&Stats.Stopfor controlling the component's lifecycle. During tests, the default stats instance is initialised, but not started.Measurement(fkaRudderStats) instances created before theStatsinstance was able to successfully create a statsd client remained muted in the previous implementation. A special test case verifies the correct behaviour (see stats_internal_test.go).Notion Ticket
Link
Security