feat: add support iam role support for warehouse destinations #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
changed the title
koladilip
changed the title
koladilip
changed the title
Codecov ReportBase: 41.35% // Head: 41.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
+ Coverage 41.35% 41.47% +0.11%
==========================================
Files 175 175
Lines 36266 36288 +22
==========================================
+ Hits 14998 15050 +52
+ Misses 20333 20303 -30
Partials 935 935
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@koladilip can you provide additional details and context regarding the changes in this PR? |
achettyiitr
approved these changes
Sep 29, 2022
@lvrach I have updated the issue description, let me know if you need more details are needed. |
…erlabs/rudder-server into feat.add-roles-support-for-redshift
koladilip
requested review from
achettyiitr and
cisse21
and removed request for
dhawal1248
|
Tested with redshift and glue, it is working fine. |
fracasula
reviewed
Sep 30, 2022
fracasula
reviewed
Sep 30, 2022
fracasula
reviewed
Sep 30, 2022
Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
fracasula
approved these changes
Sep 30, 2022
This was referenced Sep 30, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of AWS FTR we need to support IAM roles instead of access keys for all AWS interactions. We already supported for file and streaming destinations using common utils. Now I am doing the same for warehouse destinations where there is dependency on S3 for Snowflake, deltalake, Redshift and using common utils we can automatically enable support for role based authentication.
In that process I have update glue client creation to use the same common utils to support role based auth.
Notion Ticket
https://www.notion.so/rudderstacks/AWS-FTR-for-Redshift-e7dc80ee847a49d6b7bb7fc03aeeffc2
Security