fix(warehouse): default job type #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
changed the title
achettyiitr
requested review from
chaitanyapraveen,
abhimanyubabbar and
lvrach
lvrach
approved these changes
Oct 19, 2022
chaitanyapraveen
approved these changes
Oct 19, 2022
cisse21
approved these changes
Oct 19, 2022
Merged
atzoum
pushed a commit
that referenced
this pull request
Oct 19, 2022
atzoum
pushed a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For backward compatibility, the job type can be NULL. So added default handling for the job type to use for the upload flow.
Notion Ticket
https://www.notion.so/rudderstacks/PGNotifier-default-jobType-1197a7b1438847418899a9e548aaf1e6
Security