Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: applying 1.2.4 hotfixes to main branch #2597

Merged
merged 3 commits into from Oct 20, 2022
Merged

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Oct 19, 2022

Description

applying 1.2.4 hotfixes to main branch

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum changed the title chore: applying 1.2.1 hotfixes to main branch chore: applying 1.2.4 hotfixes to main branch Oct 19, 2022
@atzoum atzoum marked this pull request as ready for review October 19, 2022 15:19
Copy link
Contributor

@chaitanyapraveen chaitanyapraveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 44.00% // Head: 44.01% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (768a064) compared to base (09dba21).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
+ Coverage   44.00%   44.01%   +0.01%     
==========================================
  Files         187      187              
  Lines       39086    39086              
==========================================
+ Hits        17198    17203       +5     
+ Misses      20807    20805       -2     
+ Partials     1081     1078       -3     
Impacted Files Coverage Δ
warehouse/schema.go 47.82% <0.00%> (-1.16%) ⬇️
services/rsources/handler.go 70.55% <0.00%> (+0.83%) ⬆️
services/stats/stats.go 90.30% <0.00%> (+1.81%) ⬆️
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum requested a review from lvrach October 19, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants