refactor: use destination config from config-be than from message #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
requested review from
krishna2020,
utsabc,
saikumarrs and
sandeepdsvs
saikumarrs
reviewed
Dec 22, 2022
Codecov ReportBase: 47.21% // Head: 47.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=======================================
Coverage 47.21% 47.21%
=======================================
Files 309 309
Lines 50186 50191 +5
=======================================
+ Hits 23693 23696 +3
- Misses 25023 25026 +3
+ Partials 1470 1469 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
utsabc
reviewed
Dec 22, 2022
utsabc
approved these changes
Dec 22, 2022
Earlier transformer was sending destConfig in message and it contains secrets so it is appearing in live events so refactored code to use config from CP.
koladilip
force-pushed
the
refactor.lambda-manager
branch
from
f6ac1f9
to
3a2fd91
Compare
sandeepdsvs
approved these changes
Dec 22, 2022
saikumarrs
approved these changes
Dec 22, 2022
Closed
This was referenced Jan 10, 2023
Closed
Merged
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier transformer was sending destConfig in message and it contains secrets so it is appearing in live events so refactored code to use config from CP.
Notion Ticket
Lambda Keys exposed in Live events
Security