chore: improve regulation-worker status capture #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurav-malani
changed the base branch from
master
to
feat.MTSupportRegWorker
Codecov ReportBase: 52.97% // Head: 52.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 52.97% 52.99% +0.01%
==========================================
Files 334 334
Lines 51863 51858 -5
==========================================
+ Hits 27475 27482 +7
+ Misses 22785 22776 -9
+ Partials 1603 1600 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
saurav-malani
force-pushed
the
feat.MTSupportRegWorker
branch
from
41495e3
to
fe380fe
Compare
saurav-malani
force-pushed
the
chore.StatusDetails
branch
from
f6ad0b3
to
1aade77
Compare
saurav-malani
force-pushed
the
chore.StatusDetails
branch
from
1aade77
to
2cca050
Compare
lvrach
reviewed
Feb 23, 2023
| expectedDeleteStatus: model.JobStatusComplete, | ||
| expectedPayload: `[{"jobId":"1","destType":"ga","config":{"rudderDeleteAccountId":"xyz"},"userAttributes":[{"email":"dorowane8n285680461479465450293437@gmail.com","phone":"6463633841","randomKey":"randomValue","userId":"Jermaine1473336609491897794707338"},{"email":"dshirilad853601942465969121327991@gmail.com","userId":"Mercie8221821544021583104106123"},{"phone":"8782905113","userId":"Claiborn443446989226249191822329"}]}]`, | ||
| }, | ||
| // { |
There was a problem hiding this comment.
why those tests are commented out?
There was a problem hiding this comment.
Oops, that is mistake. I was debugging something and forgot to uncomment them back. Thanks for pointing it out. Fixed.
saurav-malani
force-pushed
the
chore.StatusDetails
branch
from
f9e468e
to
5ab6254
Compare
lvrach
approved these changes
Feb 23, 2023
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when
regulation-workerresponds toregulation-manager, it doesn't return the reason in case offailureoraborted. And, as it could be helpful in debugging and in various other cases. This PR modifies response body to return the reason too.Notion Ticket
https://www.notion.so/rudderstacks/improve-regulation-worker-status-capture-f1e82e5fe8e64ec1b88fc7df29e9325e