chore: upgrade all dependencies #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 52.95% // Head: 52.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2996 +/- ##
==========================================
+ Coverage 52.95% 52.99% +0.04%
==========================================
Files 338 334 -4
Lines 52099 51921 -178
==========================================
- Hits 27587 27517 -70
+ Misses 22897 22793 -104
+ Partials 1615 1611 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cisse21
force-pushed
the
chore.upgradeDependencies
branch
from
046ac98
to
4baf2a7
Compare
Sidddddarth
approved these changes
Feb 20, 2023
atzoum
reviewed
Feb 20, 2023
Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
…der-server into chore.upgradeDependencies
atzoum
reviewed
Feb 20, 2023
atzoum
reviewed
Feb 20, 2023
| @@ -53,5 +53,6 @@ func (rateLimiter *HandleT) SetUp() { | |||
|
|
|||
| // LimitReached returns true if number of events in the rolling window is less than the max events allowed, else false | |||
| func (rateLimiter *HandleT) LimitReached(key string) bool { | |||
| return rateLimiter.restrictor.LimitReached(key) | |||
| ok, _ := rateLimiter.restrictor.LimitReached(key) | |||
There was a problem hiding this comment.
Note: we should add a task to move away from github.com/EagleChen/restrictor since we are already using github.com/throttled/throttled/v2 elsewhere
|
Please add an appropriate description for this pull request |
atzoum
approved these changes
Feb 20, 2023
1 task
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to upgrade the Go minor version to
1.20.1, Alpine version to3.17, GolangCI Lint version to1.51.1and also the dependent packages in go.mod fileNotion Ticket
Notion Link
Security