Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer using lo.BufferWithTimeout #2998

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Feb 20, 2023

Description

Using lo.BufferWithTimeout that either waits for a number of objects to receive from a channel or a timeout whichever's first.

Notion Ticket

BufferWithTimeout

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title lo.BufferWithTimeout refactor: lo.BufferWithTimeout Feb 20, 2023
Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

router/router.go Outdated Show resolved Hide resolved
@atzoum
Copy link
Contributor

atzoum commented Feb 20, 2023

@Sidddddarth is this still work in progress, or ready for review?

@Sidddddarth Sidddddarth marked this pull request as ready for review February 20, 2023 07:09
@atzoum atzoum changed the title refactor: lo.BufferWithTimeout refactor: prefer using lo.BufferWithTimeout Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 52.98% // Head: 52.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ea9731b) compared to base (c44e602).
Patch coverage: 93.18% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2998   +/-   ##
=======================================
  Coverage   52.98%   52.98%           
=======================================
  Files         334      334           
  Lines       51885    51842   -43     
=======================================
- Hits        27489    27468   -21     
+ Misses      22790    22773   -17     
+ Partials     1606     1601    -5     
Impacted Files Coverage Δ
gateway/admin.go 0.00% <0.00%> (ø)
gateway/gateway.go 76.48% <93.33%> (+0.18%) ⬆️
processor/transformer/transformer.go 73.30% <100.00%> (-0.71%) ⬇️
router/router.go 77.56% <100.00%> (-0.35%) ⬇️
processor/worker.go 82.81% <0.00%> (-2.35%) ⬇️
processor/processor.go 87.28% <0.00%> (-0.16%) ⬇️
jobsdb/jobsdb.go 74.03% <0.00%> (+0.12%) ⬆️
...rprise/suppress-user/internal/badgerdb/badgerdb.go 83.50% <0.00%> (+0.50%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants