-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prefer using lo.BufferWithTimeout #2998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
d155904
to
3b18c4d
Compare
@Sidddddarth is this still work in progress, or ready for review? |
a312e9b
to
e98c3ef
Compare
e98c3ef
to
b830050
Compare
b830050
to
ea9731b
Compare
Codecov ReportBase: 52.98% // Head: 52.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2998 +/- ##
=======================================
Coverage 52.98% 52.98%
=======================================
Files 334 334
Lines 51885 51842 -43
=======================================
- Hits 27489 27468 -21
+ Misses 22790 22773 -17
+ Partials 1606 1601 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
Using
lo.BufferWithTimeout
that either waits for a number of objects to receive from a channel or a timeout whichever's first.Notion Ticket
BufferWithTimeout
Security