feat: kafka over ssh #3007
Merged
feat: kafka over ssh #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
force-pushed
the
feat.kafkaSsh
branch
2 times, most recently
from
495d215
to
815c764
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3007 +/- ##
==========================================
+ Coverage 53.79% 53.83% +0.04%
==========================================
Files 348 350 +2
Lines 53846 54003 +157
==========================================
+ Hits 28965 29074 +109
- Misses 23240 23281 +41
- Partials 1641 1648 +7
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lvrach
reviewed
Feb 20, 2023
lvrach
reviewed
Feb 20, 2023
| } | ||
| return conn, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we set the net Dialer with Timeout if not defined?
Suggested change
| } | |
| } | |
| dialer.DialFunc = net.Dialer{ | |
| Timeout: c.config.DialTimeout, | |
| }.DialContext |
There was a problem hiding this comment.
I've added a timeout in the SSH config. It works as expected when dialing. If not defined then the timeout in line 47 should apply. Wdyt?
fracasula
force-pushed
the
feat.kafkaSsh
branch
from
c93ac44
to
4e1b671
Compare
atzoum
reviewed
Feb 21, 2023
fracasula
force-pushed
the
feat.kafkaSsh
branch
from
01fb5cb
to
99a5019
Compare
fracasula
force-pushed
the
feat.kafkaSsh
branch
from
04437b7
to
af20123
Compare
snarkychef
reviewed
Feb 22, 2023
fracasula
force-pushed
the
feat.kafkaSsh
branch
from
f973f58
to
9a49c25
Compare
fracasula
force-pushed
the
feat.kafkaSsh
branch
from
b94bdfe
to
e30a9cb
Compare
atzoum
approved these changes
Mar 15, 2023
lvrach
approved these changes
Mar 15, 2023
This was referenced Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add support for connecting to Kafka via SSH. It is required by a specific customer and control plane prefers not to have SSH keys on their side so for this one we're opting to configure via environment variables only.
The PR was tested manually with a Kafka over SSH on AWS (EC2).
Related Slack conversation.
Sidenote
In order to make the test work I had to make changes to the way Kafka was provisioned so that the advertised listeners were set correctly.
Notion Ticket
< Notion Link >
Security