Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warehouse): default warehouse priority set to 100 #3026

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Feb 22, 2023

Description

Since the warehouse processor expects priority orders by ASC, setting the default value to 100.

Notion Ticket

https://www.notion.so/rudderstacks/Warehouse-default-priority-to-set-to-100-20f47a2db688451d97710842496972c2?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 52.95% // Head: 53.01% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (2040f25) compared to base (cc8e1dc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3026      +/-   ##
==========================================
+ Coverage   52.95%   53.01%   +0.05%     
==========================================
  Files         334      334              
  Lines       51885    51885              
==========================================
+ Hits        27478    27505      +27     
+ Misses      22797    22779      -18     
+ Partials     1610     1601       -9     
Impacted Files Coverage Δ
warehouse/warehouse.go 11.82% <0.00%> (ø)
router/router.go 77.91% <0.00%> (-0.20%) ⬇️
processor/processor.go 87.28% <0.00%> (+0.40%) ⬆️
warehouse/schema.go 55.52% <0.00%> (+1.07%) ⬆️
services/rsources/handler.go 75.20% <0.00%> (+1.37%) ⬆️
jobsdb/migration.go 77.06% <0.00%> (+3.09%) ⬆️
testhelper/log/log.go 11.53% <0.00%> (+3.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants