chore(warehouse): use first_event_at while pickup for warehouse processing jobs #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 52.97% // Head: 53.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3036 +/- ##
==========================================
+ Coverage 52.97% 53.12% +0.14%
==========================================
Files 334 334
Lines 51863 51858 -5
==========================================
+ Hits 27475 27548 +73
+ Misses 22785 22707 -78
Partials 1603 1603
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lvrach
approved these changes
Feb 27, 2023
| @@ -263,7 +264,7 @@ func (uploads *Uploads) GetToProcess(ctx context.Context, destType string, limit | |||
| grouped_uploads.row_number = 1 | |||
| ORDER BY | |||
| COALESCE(metadata->>'priority', '100')::int ASC, | |||
| id ASC | |||
| COALESCE(first_event_at, NOW()) ASC | |||
There was a problem hiding this comment.
It shouldn't be complex to write a test for first_event_at behaviour.
cisse21
reviewed
Feb 27, 2023
cisse21
approved these changes
Feb 27, 2023
|
Hey @lvrach merged this without checking the comment. @achettyiitr will add the test in another PR sorry for the trouble |
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use first_event_at while pickup for warehouse processing jobs
Notion Ticket
https://www.notion.so/rudderstacks/Use-first_event_at-while-pickup-from-processing-31c841fcdecc4ea8b6139ee0cb4d8daa?pvs=4
Security