Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default retention period set to 7 days for rudder backups #3038

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Feb 27, 2023

Description

in case of default backup retention period(7 days for now) to rudder-storage, jobs must be uploaded to bucket/7dayretention prefix(configurable via env - JOBS_BACKUP_STORAGE_DEFAULT_PREFIX).

Notion Ticket

Implement 7-day data retention policy

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title default retention period set to 7 days for rudder backups feat: default retention period set to 7 days for rudder backups Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (61d9275) 53.55% compared to head (56e3579) 53.77%.

❗ Current head 56e3579 differs from pull request most recent head 59f83c9. Consider uploading reports for the commit 59f83c9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
+ Coverage   53.55%   53.77%   +0.22%     
==========================================
  Files         350      348       -2     
  Lines       54440    53866     -574     
==========================================
- Hits        29156    28969     -187     
+ Misses      23628    23260     -368     
+ Partials     1656     1637      -19     
Impacted Files Coverage Δ
config/backend-config/types.go 74.07% <ø> (ø)
services/fileuploader/fileuploader.go 100.00% <100.00%> (+2.94%) ⬆️

... and 34 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sidddddarth Sidddddarth force-pushed the feat.backupDefaultDataRetention branch from ee3d9cc to a47046d Compare February 28, 2023 07:45
@Sidddddarth Sidddddarth force-pushed the feat.backupDefaultDataRetention branch from a47046d to 5b097bc Compare March 13, 2023 05:26
@Sidddddarth Sidddddarth marked this pull request as ready for review March 13, 2023 05:27
@Sidddddarth Sidddddarth force-pushed the feat.backupDefaultDataRetention branch from b7d92b7 to 59f83c9 Compare March 15, 2023 15:14
@cisse21 cisse21 merged commit 0d9af35 into master Mar 16, 2023
@cisse21 cisse21 deleted the feat.backupDefaultDataRetention branch March 16, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants