fix(warehouse): grouping uploads for processing pickup #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re.processor-pickup-first_event_at
…re.processor-pickup-first_event_at
cisse21
approved these changes
Feb 27, 2023
achettyiitr
force-pushed
the
fix.first-event-grouping
branch
from
69921a5
to
2861ce2
Compare
achettyiitr
changed the title
lvrach
reviewed
Feb 27, 2023
| @@ -140,6 +143,364 @@ func TestUploads_Get(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestUploads_GetToProcess(t *testing.T) { | |||
There was a problem hiding this comment.
[minor] Some of the tests presented here could have been combined with TestUploads_Processing
There was a problem hiding this comment.
Missed that test. Because of time constraints, Will merge both of the tests in separate PR.
lvrach
approved these changes
Feb 27, 2023
Codecov ReportBase: 53.00% // Head: 52.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3039 +/- ##
==========================================
- Coverage 53.00% 52.97% -0.03%
==========================================
Files 334 334
Lines 51873 51874 +1
==========================================
- Hits 27493 27479 -14
- Misses 22782 22793 +11
- Partials 1598 1602 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use first_event_at for grouping while pickup for warehouse processing jobs
Notion Ticket
https://www.notion.so/rudderstacks/Use-first_event_at-while-pickup-from-processing-31c841fcdecc4ea8b6139ee0cb4d8daa?pvs=4
Security