-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user/anonymous id read at gateway #3051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we have some test cases?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/1.6.x #3051 +/- ##
=================================================
- Coverage 53.72% 52.87% -0.86%
=================================================
Files 338 338
Lines 54599 52120 -2479
=================================================
- Hits 29336 27559 -1777
+ Misses 23587 22958 -629
+ Partials 1676 1603 -73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ef4a565
to
8a0f5c6
Compare
Description
Losing typecase to avoid missing out on events where
userId
/anonymousId
is not of type string.Notion Ticket
gateway userId read fix
Security