Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user/anonymous id read at gateway #3051

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

Sidddddarth
Copy link
Member

Description

Losing typecase to avoid missing out on events where userId/anonymousId is not of type string.

Notion Ticket

gateway userId read fix

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we have some test cases?

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.86 ⚠️

Comparison is base (9712cf9) 53.72% compared to head (8a0f5c6) 52.87%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.6.x    #3051      +/-   ##
=================================================
- Coverage          53.72%   52.87%   -0.86%     
=================================================
  Files                338      338              
  Lines              54599    52120    -2479     
=================================================
- Hits               29336    27559    -1777     
+ Misses             23587    22958     -629     
+ Partials            1676     1603      -73     
Impacted Files Coverage Δ
gateway/gateway.go 76.30% <100.00%> (-6.43%) ⬇️
regulation-worker/internal/delete/batch/batch.go 50.56% <0.00%> (-7.93%) ⬇️
jobsdb/unionQuery.go 84.13% <0.00%> (-7.03%) ⬇️
router/router.go 78.26% <0.00%> (-6.66%) ⬇️
warehouse/integrations/postgres/postgres.go 26.18% <0.00%> (-5.62%) ⬇️
processor/transformer/transformer.go 74.00% <0.00%> (-5.41%) ⬇️
jobsdb/jobsdb.go 74.03% <0.00%> (-5.28%) ⬇️
regulation-worker/internal/service/service.go 73.07% <0.00%> (-5.26%) ⬇️
regulation-worker/internal/client/client.go 70.86% <0.00%> (-4.87%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants