Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warehouse): warehouse integration tests improvements #3059

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Mar 1, 2023

Description

  1. increase timeouts for the backend container
  2. improve logs in case of a failed setup
  3. update databricks connector to v1.4.2

Notion Ticket

https://www.notion.so/rudderstacks/Warehouse-integration-tests-fix-c45039d9faa2481b9772d00beebfdd4c?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the chore.warehouse-integration-tests branch from 985e93c to 0be4832 Compare March 1, 2023 10:40
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (b732919) 52.75% compared to head (0be4832) 52.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3059      +/-   ##
==========================================
- Coverage   52.75%   52.65%   -0.11%     
==========================================
  Files         334      334              
  Lines       52198    52198              
==========================================
- Hits        27537    27484      -53     
- Misses      23057    23121      +64     
+ Partials     1604     1593      -11     
Impacted Files Coverage Δ
config/backend-config/noop.go 0.00% <0.00%> (-42.11%) ⬇️
processor/stash/stash.go 45.25% <0.00%> (-21.54%) ⬇️
jobsdb/backup.go 75.40% <0.00%> (-0.36%) ⬇️
jobsdb/migration.go 76.28% <0.00%> (+1.03%) ⬆️
services/rsources/handler.go 75.20% <0.00%> (+1.37%) ⬆️
config/backend-config/namespace_config.go 73.00% <0.00%> (+3.00%) ⬆️
router/manager/manager.go 100.00% <0.00%> (+3.29%) ⬆️
testhelper/log/log.go 11.53% <0.00%> (+3.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants