-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use upload_id for staging files #3066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
force-pushed
the
chore.useUploadID
branch
from
March 6, 2023 07:14
c99436b
to
74cb5f3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3066 +/- ##
==========================================
+ Coverage 53.37% 53.39% +0.01%
==========================================
Files 342 342
Lines 52812 52735 -77
==========================================
- Hits 28191 28157 -34
+ Misses 23004 22965 -39
+ Partials 1617 1613 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cisse21
force-pushed
the
chore.useUploadID
branch
5 times, most recently
from
March 6, 2023 11:40
32a8997
to
f23b84c
Compare
cisse21
force-pushed
the
chore.useUploadID
branch
5 times, most recently
from
March 6, 2023 13:12
cb1956e
to
9fd555f
Compare
cisse21
force-pushed
the
chore.useUploadID
branch
2 times, most recently
from
March 6, 2023 14:31
8044edb
to
a00006f
Compare
cisse21
force-pushed
the
chore.useUploadID
branch
from
March 6, 2023 15:05
a00006f
to
3e79575
Compare
cisse21
force-pushed
the
chore.useUploadID
branch
from
March 7, 2023 06:20
c6b9da1
to
9063061
Compare
lvrach
approved these changes
Mar 7, 2023
achettyiitr
approved these changes
Mar 7, 2023
This was referenced Mar 8, 2023
This was referenced Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
upload_id
for staging files instead ofstart_staging_file_id
andend_staging_file_id
Notion Ticket
Notion Link
Security