Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use upload_id for staging files #3066

Merged
merged 5 commits into from
Mar 7, 2023
Merged

chore: use upload_id for staging files #3066

merged 5 commits into from
Mar 7, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Mar 6, 2023

Description

Use upload_id for staging files instead of start_staging_file_id and end_staging_file_id

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.01 🎉

Comparison is base (4cb5907) 53.37% compared to head (818a6b7) 53.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
+ Coverage   53.37%   53.39%   +0.01%     
==========================================
  Files         342      342              
  Lines       52812    52735      -77     
==========================================
- Hits        28191    28157      -34     
+ Misses      23004    22965      -39     
+ Partials     1617     1613       -4     
Impacted Files Coverage Δ
warehouse/identities.go 1.08% <ø> (+0.03%) ⬆️
warehouse/warehouse.go 11.77% <2.40%> (-0.05%) ⬇️
warehouse/internal/repo/staging.go 80.92% <75.00%> (-0.12%) ⬇️
warehouse/api.go 69.89% <100.00%> (ø)
warehouse/internal/repo/upload.go 82.32% <100.00%> (-0.09%) ⬇️
warehouse/internal/service/staging.go 100.00% <100.00%> (ø)
services/rsources/handler.go 74.65% <0.00%> (-0.56%) ⬇️
router/router.go 77.67% <0.00%> (-0.20%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 force-pushed the chore.useUploadID branch 5 times, most recently from 32a8997 to f23b84c Compare March 6, 2023 11:40
@cisse21 cisse21 force-pushed the chore.useUploadID branch 5 times, most recently from cb1956e to 9fd555f Compare March 6, 2023 13:12
@cisse21 cisse21 force-pushed the chore.useUploadID branch 2 times, most recently from 8044edb to a00006f Compare March 6, 2023 14:31
@cisse21 cisse21 marked this pull request as ready for review March 6, 2023 14:32
@cisse21 cisse21 merged commit 3ec2433 into master Mar 7, 2023
@cisse21 cisse21 deleted the chore.useUploadID branch March 7, 2023 10:58
saurav-malani

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants