Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending events all #3075

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix: pending events all #3075

merged 2 commits into from
Mar 8, 2023

Conversation

fracasula
Copy link
Collaborator

@fracasula fracasula commented Mar 7, 2023

Description

Adding new metric to query pending events on hosted given that workspaceId gets filtered out for free users.
Router pickup jobs won't be affected since they use their own in memory implementation.

Tested on dev.

Notion Ticket

< Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@fracasula fracasula changed the title fix: pending events all [WIP] fix: pending events all Mar 7, 2023
@fracasula fracasula changed the title [WIP] fix: pending events all fix: pending events all Mar 7, 2023
@fracasula fracasula requested review from atzoum and lvrach March 7, 2023 17:20
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 84.03% and project coverage change: +0.29 🎉

Comparison is base (1b6af85) 53.09% compared to head (9293e49) 53.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
+ Coverage   53.09%   53.38%   +0.29%     
==========================================
  Files         332      342      +10     
  Lines       52350    52893     +543     
==========================================
+ Hits        27794    28236     +442     
- Misses      22956    23035      +79     
- Partials     1600     1622      +22     
Impacted Files Coverage Δ
app/apphandlers/gatewayAppHandler.go 13.82% <ø> (ø)
app/apphandlers/setup.go 73.25% <ø> (ø)
gateway/internal/stats/stats.go 100.00% <ø> (ø)
jobsdb/admin.go 68.99% <0.00%> (ø)
runner/runner.go 69.66% <50.00%> (-0.61%) ⬇️
services/metric/registry.go 82.25% <50.00%> (-0.15%) ⬇️
testhelper/stats/prometheus.go 57.14% <57.14%> (ø)
regulation-worker/cmd/main.go 71.95% <62.50%> (-1.39%) ⬇️
services/stats/otel.go 73.00% <73.00%> (ø)
services/stats/statsd_measurement.go 75.55% <75.55%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum changed the base branch from prerelease/1.7.0-preview.2 to master March 7, 2023 17:25
@fracasula fracasula merged commit 1d9f63b into master Mar 8, 2023
@fracasula fracasula deleted the fix.pendingEventsAll branch March 8, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants