chore(warehouse): encoding package with readers, loaders, writers #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
approved these changes
Mar 8, 2023
2. Use %q to quote a string in fmt.Sprintf format specifiers 3. Unnecessary block
achettyiitr
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3077 +/- ##
==========================================
+ Coverage 53.60% 53.82% +0.22%
==========================================
Files 346 348 +2
Lines 53805 53819 +14
==========================================
+ Hits 28840 28968 +128
+ Misses 23328 23213 -115
- Partials 1637 1638 +1
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lvrach
reviewed
Mar 10, 2023
warehouse/encoding/encoding.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| UuidTsColumn = "uuid_ts" |
There was a problem hiding this comment.
Suggested change
| UuidTsColumn = "uuid_ts" | |
| UUIDTsColumn = "uuid_ts" |
achettyiitr
force-pushed
the
chore.schema-1
branch
from
4e8f72c
to
ad9ecf6
Compare
achettyiitr
force-pushed
the
chore.encoding
branch
from
6f9d6af
to
20d2568
Compare
cisse21
approved these changes
Mar 13, 2023
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/encoding-with-readers-loaders-writers-5c4e2c63bf49411ebe403a8fdc07ba14?pvs=4
Security