Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable pipeline level sync frequency #3094

Merged
merged 8 commits into from
Mar 14, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Mar 13, 2023

Description

Support sync frequency at connection level

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.13 🎉

Comparison is base (b9deb4a) 53.80% compared to head (cb85f07) 53.94%.

❗ Current head cb85f07 differs from pull request most recent head e83d7d3. Consider uploading reports for the commit e83d7d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
+ Coverage   53.80%   53.94%   +0.13%     
==========================================
  Files         348      348              
  Lines       53847    53855       +8     
==========================================
+ Hits        28974    29050      +76     
+ Misses      23233    23164      -69     
- Partials     1640     1641       +1     
Impacted Files Coverage Δ
processor/stash/stash.go 66.78% <ø> (+21.53%) ⬆️
utils/misc/misc.go 51.44% <ø> (-0.28%) ⬇️
warehouse/warehouse.go 11.59% <0.00%> (ø)
warehouse/scheduling.go 61.49% <100.00%> (ø)
warehouse/utils/utils.go 73.15% <100.00%> (+0.22%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 marked this pull request as ready for review March 13, 2023 15:18
warehouse/utils/utils.go Outdated Show resolved Hide resolved
@cisse21 cisse21 merged commit ea3bbd5 into master Mar 14, 2023
@cisse21 cisse21 deleted the chore.syncFrequencyUpgrade branch March 14, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants