Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warehouse): allow empty properties schema for event models #3095

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Jayachand
Copy link
Contributor

@Jayachand Jayachand commented Mar 13, 2023

Description

Empty schema is allowed in json schema obtained from event models

Notion Ticket

https://www.notion.so/rudderstacks/Spreadsheet-Show-all-events-from-event-models-irrespective-of-no-properties-10c9bb3afe4e4340b1a0bf95c10e154e?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Jayachand Jayachand changed the title chore(eventschema): allow empty properties schema for event models chore(warehouse): allow empty properties schema for event models Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 47.70% and project coverage change: +0.15 🎉

Comparison is base (f2e99c7) 53.62% compared to head (2465bbc) 53.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
+ Coverage   53.62%   53.78%   +0.15%     
==========================================
  Files         347      348       +1     
  Lines       53806    53847      +41     
==========================================
+ Hits        28853    28960     +107     
+ Misses      23320    23248      -72     
- Partials     1633     1639       +6     
Impacted Files Coverage Δ
event-schema/event_schema_api.go 0.00% <0.00%> (ø)
warehouse/identity/identity.go 0.51% <0.00%> (ø)
warehouse/slave.go 1.05% <0.00%> (ø)
warehouse/utils/utils.go 72.93% <ø> (-0.12%) ⬇️
warehouse/warehouse.go 11.59% <0.00%> (-0.19%) ⬇️
warehouse/encoding/csvloader.go 80.00% <50.00%> (ø)
warehouse/encoding/jsonloader.go 83.72% <73.68%> (ø)
warehouse/encoding/jsonreader.go 70.00% <77.77%> (ø)
warehouse/internal/repo/upload.go 83.36% <82.35%> (-0.04%) ⬇️
runner/runner.go 69.88% <100.00%> (+0.11%) ⬆️
... and 7 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants