Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: badgerDB improvements for debugger #3101

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Mar 15, 2023

Description

  1. Using 1MB as valueThreshold by default (this is what we are using now through an override)
  2. Using 5 minutes as ttl by default (30 seconds is too short)
  3. Cleanup badgerDB folder on startup by default (transitive data)

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.04 ⚠️

Comparison is base (0eeaeb5) 53.46% compared to head (2b0ff2e) 53.43%.

❗ Current head 2b0ff2e differs from pull request most recent head 62ef056. Consider uploading reports for the commit 62ef056 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
- Coverage   53.46%   53.43%   -0.04%     
==========================================
  Files         348      348              
  Lines       54183    54188       +5     
==========================================
- Hits        28967    28953      -14     
- Misses      23580    23592      +12     
- Partials     1636     1643       +7     
Impacted Files Coverage Δ
services/debugger/cache/internal/badger/badger.go 75.42% <66.66%> (-1.57%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit 0c525d0 into master Mar 15, 2023
@atzoum atzoum deleted the chore.badgerOptimisation branch March 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants