Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kafka create topic #3102

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix: kafka create topic #3102

merged 2 commits into from
Mar 15, 2023

Conversation

fracasula
Copy link
Collaborator

@fracasula fracasula commented Mar 15, 2023

Description

To fix these builds.

Context

Some integration tests running with more than one Kafka broker would occasionally fail. That is because the creation of topics and other administration operations have to be done directly on the broker that is the "controller" of such topic.

Notion Ticket

< Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 73.30% and project coverage change: +0.08 🎉

Comparison is base (0eeaeb5) 53.46% compared to head (15a1e67) 53.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
+ Coverage   53.46%   53.54%   +0.08%     
==========================================
  Files         348      350       +2     
  Lines       54183    54374     +191     
==========================================
+ Hits        28967    29114     +147     
- Misses      23580    23613      +33     
- Partials     1636     1647      +11     
Impacted Files Coverage Δ
services/streammanager/kafka/client/config.go 60.27% <ø> (ø)
testhelper/destination/common.go 0.00% <0.00%> (ø)
warehouse/integrations/snowflake/snowflake.go 1.02% <ø> (ø)
testhelper/destination/sshserver/sshserver.go 65.78% <65.78%> (ø)
services/streammanager/kafka/client/client.go 83.52% <68.00%> (-6.48%) ⬇️
...rvices/streammanager/kafka/client/testutil/util.go 69.44% <72.72%> (-1.43%) ⬇️
testhelper/destination/kafka.go 80.66% <83.78%> (+2.19%) ⬆️
services/streammanager/kafka/kafkamanager.go 76.77% <90.62%> (+1.02%) ⬆️
services/streammanager/kafka/client/producer.go 79.81% <100.00%> (-0.55%) ⬇️
testhelper/destination/minio.go 70.00% <100.00%> (ø)
... and 3 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum requested review from lvrach and cisse21 March 15, 2023 10:57
@fracasula fracasula merged commit 10ccbf3 into master Mar 15, 2023
@fracasula fracasula deleted the fix.kafkaCreateTopic branch March 15, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants