chore: change stash defaults #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Mar 29, 2023
processor/stash/stash.go
Outdated
Comment on lines
43
to
44
| config.RegisterDurationConfigVariable(5, &errReadLoopSleep, true, time.Second, []string{"Processor.errReadLoopSleep", "errReadLoopSleepInS"}...) | ||
| config.RegisterIntConfigVariable(10000, &errDBReadBatchSize, true, 1, "Processor.errDBReadBatchSize") |
There was a problem hiding this comment.
We can keep the current numbers and skip sleeping for errReadLoopSleep until the stash loop picks up less jobs than the errDBReadBatchSize. This way we can keep memory utilisation low and flush fast at the same time
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
atzoum
approved these changes
Apr 24, 2023
BonapartePC
approved these changes
Apr 24, 2023
Closed
Merged
This was referenced May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable faster flushing of proc error tables
Notion Ticket
Notion Link
Security