Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lo to slices in eventfilter package #3238

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

sanpj2292
Copy link
Contributor

Description

We want to maintain convention of using slices over lo package across the repository

Notion Ticket

https://www.notion.so/rudderstacks/GA4-page-calls-error-is-displaying-in-live-events-tab-for-hybrid-mode-connection-52c58ee1924941f1b037fb8f63fc2445?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 self-assigned this Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (bba4894) 51.78% compared to head (a761275) 51.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
+ Coverage   51.78%   51.83%   +0.05%     
==========================================
  Files         319      319              
  Lines       53184    53184              
==========================================
+ Hits        27540    27569      +29     
+ Misses      23988    23969      -19     
+ Partials     1656     1646      -10     
Impacted Files Coverage Δ
processor/eventfilter/eventfilter.go 91.66% <100.00%> (ø)

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanpj2292 sanpj2292 merged commit 0a91574 into master Apr 24, 2023
21 checks passed
@sanpj2292 sanpj2292 deleted the fix.lo-to-slices-eventfilter branch April 24, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants