Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated merged schema field #3482

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Jun 12, 2023

Description

Getting rid of the deprecated mergedschema field from warehouse tables

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (b525949) 68.01% compared to head (b597db9) 68.03%.

❗ Current head b597db9 differs from pull request most recent head b662575. Consider uploading reports for the commit b662575 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.02%     
==========================================
  Files         330      330              
  Lines       53574    53560      -14     
==========================================
+ Hits        36437    36440       +3     
+ Misses      14740    14725      -15     
+ Partials     2397     2395       -2     
Impacted Files Coverage Δ
warehouse/internal/model/upload.go 100.00% <ø> (ø)
warehouse/internal/repo/upload.go 83.29% <ø> (+0.43%) ⬆️
warehouse/upload.go 64.52% <ø> (+0.10%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 marked this pull request as ready for review June 12, 2023 11:55
Comment on lines 1 to 2
ALTER TABLE wh_uploads
DROP COLUMN IF EXISTS mergedschema;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the column in a release/separate PR?

So we are able to revert back without manual intervention

@cisse21 cisse21 merged commit 39a0915 into master Jun 14, 2023
28 of 29 checks passed
@cisse21 cisse21 deleted the chore.removeDeprecatedMergedSchema branch June 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants