chore: added trino and spark test #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
chore.trino-test
branch
4 times, most recently
from
fe7f3d3
to
6293162
Compare
achettyiitr
force-pushed
the
chore.trino-test
branch
from
6293162
to
4ff9587
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3525 +/- ##
==========================================
+ Coverage 68.05% 68.12% +0.06%
==========================================
Files 318 318
Lines 50382 50382
==========================================
+ Hits 34289 34324 +35
+ Misses 13867 13835 -32
+ Partials 2226 2223 -3 ☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Jun 22, 2023
achettyiitr
force-pushed
the
chore.trino-test
branch
2 times, most recently
from
0df87f7
to
76b62a9
Compare
achettyiitr
force-pushed
the
chore.trino-test
branch
from
76b62a9
to
1f6da05
Compare
achettyiitr
changed the title
achettyiitr
force-pushed
the
chore.trino-test
branch
from
f0bb66d
to
843ba1a
Compare
achettyiitr
force-pushed
the
chore.trino-test
branch
from
7e88b67
to
ebe94c3
Compare
achettyiitr
force-pushed
the
chore.trino-test
branch
from
ebe94c3
to
ac88374
Compare
lvrach
approved these changes
Jul 5, 2023
fracasula
approved these changes
Jul 13, 2023
| require.Eventually(t, func() bool { | ||
| _, err := db.ExecContext(ctx, "SELECT 1") | ||
| return err == nil | ||
| }, 60*time.Second, 1*time.Second) |
There was a problem hiding this comment.
We could try more often, we don't even have log pollution here. Every 100ms for example could work.
|
|
||
| var count int64 | ||
|
|
||
| require.NoError(t, testhelper.WithConstantRetries(func() error { |
There was a problem hiding this comment.
I suggest using require.Eventually with a short interval here as well, for sure one that is a fraction of a second. Same applies for others below.
fracasula
approved these changes
Jul 13, 2023
achettyiitr
force-pushed
the
chore.trino-test
branch
from
26a6247
to
fc1a3fa
Compare
achettyiitr
force-pushed
the
chore.trino-test
branch
from
fc1a3fa
to
c8d815b
Compare
This was referenced Jul 23, 2023
This was referenced Jul 23, 2023
Closed
Closed
Closed
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/Investigate-parquet-issue-for-AWS-GLUE-Presto-trino-6c8280c81d3a47eb9d54138586ab44d0?pvs=4
Security