Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user transformations timeout #3583

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jul 5, 2023

Description

  • Add support for handling panics in case of user transformations for timeouts.
  • Small refactoring around removing globals.

Notion Ticket

https://www.notion.so/rudderstacks/Hosted-abort-jobs-timed-out-during-UT-c21526789be046b3bec857bd239b8ae3?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the fix.user-transformer-timeout-crash branch 3 times, most recently from 9dcc704 to 4c6975c Compare July 5, 2023 14:34
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 85.62% and project coverage change: +0.03 🎉

Comparison is base (9e7f117) 68.08% compared to head (6cd9191) 68.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3583      +/-   ##
==========================================
+ Coverage   68.08%   68.12%   +0.03%     
==========================================
  Files         318      318              
  Lines       50271    50382     +111     
==========================================
+ Hits        34229    34324      +95     
- Misses      13816    13841      +25     
+ Partials     2226     2217       -9     
Impacted Files Coverage Δ
enterprise/replay/replay.go 0.00% <0.00%> (ø)
enterprise/replay/sourceWorker.go 0.00% <0.00%> (ø)
runner/runner.go 70.51% <ø> (-0.24%) ⬇️
processor/trackingplan.go 53.38% <54.54%> (ø)
processor/transformer/transformer.go 90.25% <88.80%> (+18.39%) ⬆️
processor/eventfilter/eventfilter.go 91.66% <100.00%> (ø)
processor/integrations/integrations.go 63.51% <100.00%> (+3.71%) ⬆️
processor/manager.go 94.73% <100.00%> (+0.09%) ⬆️
processor/processor.go 87.49% <100.00%> (-0.12%) ⬇️
...ger/transformation/transformationStatusUploader.go 43.01% <100.00%> (ø)
... and 1 more

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr force-pushed the fix.user-transformer-timeout-crash branch from 4c6975c to ffcac60 Compare July 5, 2023 17:59
@achettyiitr achettyiitr force-pushed the fix.user-transformer-timeout-crash branch 2 times, most recently from 33d01ae to 3e68a3c Compare July 6, 2023 05:05
@achettyiitr achettyiitr force-pushed the fix.user-transformer-timeout-crash branch from 3e68a3c to 83fc2ed Compare July 6, 2023 05:13
Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have provided some comments which suggest to perform some further refactoring on this package

processor/integrations/integrations.go Outdated Show resolved Hide resolved
runner/runner.go Show resolved Hide resolved
processor/transformer/transformer.go Show resolved Hide resolved
processor/transformer/transformer.go Outdated Show resolved Hide resolved
processor/transformer/transformer.go Outdated Show resolved Hide resolved
processor/transformer/transformer.go Outdated Show resolved Hide resolved
processor/transformer/transformer.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr force-pushed the fix.user-transformer-timeout-crash branch from 60761f5 to 65f27f0 Compare July 7, 2023 11:13
@achettyiitr achettyiitr requested a review from atzoum July 10, 2023 06:42
processor/processor_test.go Show resolved Hide resolved
processor/transformer/transformer.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr merged commit 0f6a865 into master Jul 13, 2023
36 checks passed
@achettyiitr achettyiitr deleted the fix.user-transformer-timeout-crash branch July 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants