Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warehouse stringmap configs are lower case w.r.t viper #3592

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jul 6, 2023

Description

  • Since viper internally stores its keys in lowercase, we need to compare checking with lowercase for StringMap

Notion Ticket

https://www.notion.so/rudderstacks/warehouse-config-string-map-comparision-in-lower-case-941eae92d77946fc9f41be8d17e5f685?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.29 ⚠️

Comparison is base (a8abd1d) 68.31% compared to head (ab3762b) 68.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3592      +/-   ##
==========================================
- Coverage   68.31%   68.03%   -0.29%     
==========================================
  Files         318      318              
  Lines       50284    50280       -4     
==========================================
- Hits        34353    34207     -146     
- Misses      13699    13846     +147     
+ Partials     2232     2227       -5     
Impacted Files Coverage Δ
warehouse/internal/loadfiles/loadfiles.go 75.43% <0.00%> (ø)
warehouse/upload.go 64.69% <0.00%> (-9.66%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 merged commit 5c27ac2 into master Jul 7, 2023
50 of 54 checks passed
@cisse21 cisse21 deleted the fix.warehouse-config branch July 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants