fix: cleanup for warehouse integration tests #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
approved these changes
Jul 7, 2023
achettyiitr
force-pushed
the
fix.integration-test-cleanup
branch
from
5af3529
to
2ec3d9f
Compare
achettyiitr
force-pushed
the
fix.integration-test-cleanup
branch
from
2ec3d9f
to
06182e7
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3596 +/- ##
==========================================
+ Coverage 68.01% 68.38% +0.36%
==========================================
Files 318 318
Lines 50375 50375
==========================================
+ Hits 34262 34448 +186
+ Misses 13880 13699 -181
+ Partials 2233 2228 -5 ☔ View full report in Codecov by Sentry. |
cisse21
approved these changes
Jul 11, 2023
This was referenced Jul 23, 2023
This was referenced Jul 23, 2023
Closed
Closed
Closed
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since validation tests are also running which creates the schema but not drops it. Added cleanup during validations.
Notion Ticket
https://www.notion.so/rudderstacks/Cleanup-integration-tests-fa75cc8c7d9e4ce887988a107d1f684f?pvs=4
Security