Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jobsdb): increase maintenance operation timeouts and make them hot-reloadable #3601

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Jul 7, 2023

Description

In scenarios where the database is being throttled, database query delays can cause jobsdb's maintenance operations to take much longer.
Usually, a maintenance operation times out when it doesn't manage to acquire a write lock in time. But this operation will keep retrying periodically and will be timing out continuously, causing the system to come to a standstill (a waiting write lock causes any other read lock requests to block too).
Therefore increasing timeouts to more sensible values (10m) and making them hot-reloadable as well

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4171517) 68.16% compared to head (120591d) 68.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3601   +/-   ##
=======================================
  Coverage   68.16%   68.17%           
=======================================
  Files         319      319           
  Lines       50445    50445           
=======================================
+ Hits        34387    34390    +3     
+ Misses      13841    13834    -7     
- Partials     2217     2221    +4     
Impacted Files Coverage Δ
jobsdb/jobsdb.go 72.63% <100.00%> (+0.12%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit 1c94c53 into master Jul 24, 2023
36 checks passed
@atzoum atzoum deleted the chore.jobsdbTimeouts branch July 24, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants