Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redshift dedup pick latest entry #3603

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jul 7, 2023

Description

  • In case of duplicate entries, always try to pick the latest entries.

Notion Ticket

https://www.notion.so/rudderstacks/redshift-dedup-pick-latest-entry-4c3bbcc8e91e4272865cee051c1f02c2?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (5c27ac2) 68.02% compared to head (234af4b) 67.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3603      +/-   ##
==========================================
- Coverage   68.02%   67.94%   -0.09%     
==========================================
  Files         318      318              
  Lines       50375    50375              
==========================================
- Hits        34269    34227      -42     
- Misses      13875    13916      +41     
- Partials     2231     2232       +1     
Impacted Files Coverage Δ
warehouse/integrations/redshift/redshift.go 66.69% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr merged commit 3d0536b into master Jul 11, 2023
45 of 46 checks passed
@achettyiitr achettyiitr deleted the fix.redshift-dedup-received-at-desc branch July 11, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants