Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add index on reported_at column of reports table #3606

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

satishrudderstack
Copy link
Contributor

@satishrudderstack satishrudderstack commented Jul 10, 2023

Description

  • Adding index on reported_at on reports table which is used by reporting queries

Notion Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@satishrudderstack satishrudderstack marked this pull request as draft July 10, 2023 06:03
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19 ⚠️

Comparison is base (cfee014) 68.29% compared to head (8fc345d) 68.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   68.29%   68.11%   -0.19%     
==========================================
  Files         318      318              
  Lines       50382    50382              
==========================================
- Hits        34408    34316      -92     
- Misses      13749    13840      +91     
- Partials     2225     2226       +1     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satishrudderstack satishrudderstack marked this pull request as ready for review July 14, 2023 05:29
@satishrudderstack satishrudderstack merged commit 26c1791 into master Jul 18, 2023
44 checks passed
@satishrudderstack satishrudderstack deleted the fix.add-index-on-reported-at branch July 18, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants