chore: add provision to disable tracking event names from a source for reporting #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
+ Coverage 68.09% 68.11% +0.01%
==========================================
Files 318 318
Lines 50364 50371 +7
==========================================
+ Hits 34295 34308 +13
+ Misses 13848 13840 -8
- Partials 2221 2223 +2
☔ View full report in Codecov by Sentry. |
lvrach
reviewed
Jul 18, 2023
enterprise/reporting/reporting.go
Outdated
Comment on lines
75
to
79
| sourcesWithEventNameTrackingDisabledEnv := config.GetString("SOURCES_WITH_EVENT_NAME_TRACKING_DISABLED", "") | ||
| sourcesWithEventNameTrackingDisabled := []string{} | ||
| if len(sourcesWithEventNameTrackingDisabledEnv) > 0 { | ||
| sourcesWithEventNameTrackingDisabled = strings.Split(sourcesWithEventNameTrackingDisabledEnv, ",") | ||
| } |
There was a problem hiding this comment.
GetStringSlice can be used instead.
Suggested change
| sourcesWithEventNameTrackingDisabledEnv := config.GetString("SOURCES_WITH_EVENT_NAME_TRACKING_DISABLED", "") | |
| sourcesWithEventNameTrackingDisabled := []string{} | |
| if len(sourcesWithEventNameTrackingDisabledEnv) > 0 { | |
| sourcesWithEventNameTrackingDisabled = strings.Split(sourcesWithEventNameTrackingDisabledEnv, ",") | |
| } | |
| sourcesWithEventNameTrackingDisabled := config.GetStringSlice("SOURCES_WITH_EVENT_NAME_TRACKING_DISABLED", "") |
lvrach
reviewed
Jul 18, 2023
enterprise/reporting/reporting.go
Outdated
Comment on lines
591
to
594
| if r.IsEventNameTrackingDisabledForSource(metric.ConnectionDetails.SourceID) { | ||
| metric = transformMetricForEventNameTrackingDisabled(metric) | ||
| } | ||
|
|
There was a problem hiding this comment.
A few suggestions that are somewhat idiomatic and a bit subjective:
- I would use slices.Contains, for consistency and readability.
- I would not create new functions since the logic they are encapsulating is so simple, one line each assuming
slices.Containsis used.
Suggested change
| if r.IsEventNameTrackingDisabledForSource(metric.ConnectionDetails.SourceID) { | |
| metric = transformMetricForEventNameTrackingDisabled(metric) | |
| } | |
| if slices.Contains(sourcesWithEventNameTrackingDisabled, metric.ConnectionDetails.SourceID) { | |
| metric.StatusDetail.EventName = metric.StatusDetail.EventType | |
| } |
lvrach
approved these changes
Jul 18, 2023
|
@lvrach addressed the review comments |
cisse21
approved these changes
Jul 18, 2023
This was referenced Jul 23, 2023
This was referenced Jul 23, 2023
Closed
Closed
Closed
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
event_namefield. These were all user_ids. This causes cardinality increase in reportingevent_nametracking for reporting from sourceNotion Ticket
https://www.notion.so/rudderstacks/Reports-Flush-Issue-from-Rudder-Server-Instance-9-on-prousmtusmt-c9592bd2b2b74d05a9e083ad8baa7988
Security