-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup integrations package #3635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re.integrations-cleanup
achettyiitr
force-pushed
the
chore.integrations-cleanup
branch
2 times, most recently
from
July 14, 2023 12:26
266e3c0
to
c8ea0ca
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3635 +/- ##
==========================================
- Coverage 68.29% 68.08% -0.22%
==========================================
Files 318 318
Lines 50382 50364 -18
==========================================
- Hits 34408 34289 -119
- Misses 13749 13852 +103
+ Partials 2225 2223 -2
☔ View full report in Codecov by Sentry. |
…re.integrations-cleanup
achettyiitr
force-pushed
the
chore.integrations-cleanup
branch
from
July 14, 2023 12:50
c8ea0ca
to
56c826d
Compare
fracasula
approved these changes
Jul 17, 2023
cisse21
approved these changes
Jul 18, 2023
This was referenced Jul 23, 2023
This was referenced Jul 23, 2023
Closed
Closed
Closed
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
uploader
,loadFileDownloader
, andwarehouse
fields as well into the constructor in order to have a single producer setup.Notion Ticket
https://www.notion.so/rudderstacks/cleanup-integrations-package-0b45abc8e39b466aa06192eee5910edc?pvs=4
Security