Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warehouse sql stats #3638

Merged
merged 11 commits into from
Jul 21, 2023
Merged

chore: warehouse sql stats #3638

merged 11 commits into from
Jul 21, 2023

Conversation

fracasula
Copy link
Collaborator

Description

Adding stats to SQL query wrapper.

Notion Ticket

< Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 85.07% and project coverage change: +0.09 🎉

Comparison is base (fdef25b) 68.07% compared to head (bc8e6f8) 68.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3638      +/-   ##
==========================================
+ Coverage   68.07%   68.16%   +0.09%     
==========================================
  Files         318      319       +1     
  Lines       50364    50437      +73     
==========================================
+ Hits        34285    34382      +97     
+ Misses      13850    13833      -17     
+ Partials     2229     2222       -7     
Impacted Files Coverage Δ
warehouse/jobs/runner.go 59.37% <67.34%> (+1.74%) ⬆️
...use/integrations/middleware/sqlquerywrapper/sql.go 92.44% <94.28%> (+0.02%) ⬆️
warehouse/utils/querytype.go 95.00% <95.00%> (ø)
warehouse/integrations/deltalake/deltalake.go 74.23% <100.00%> (+0.02%) ⬆️
warehouse/integrations/postgres/postgres.go 76.97% <100.00%> (+0.07%) ⬆️
warehouse/integrations/redshift/redshift.go 66.78% <100.00%> (+0.02%) ⬆️
warehouse/integrations/snowflake/snowflake.go 64.86% <100.00%> (+0.03%) ⬆️
warehouse/upload.go 64.61% <100.00%> (-0.09%) ⬇️
warehouse/warehouse.go 65.14% <100.00%> (+0.44%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fracasula fracasula marked this pull request as ready for review July 14, 2023 15:25
@cisse21 cisse21 merged commit e20976d into master Jul 21, 2023
36 checks passed
@cisse21 cisse21 deleted the chore.whSqlStats branch July 21, 2023 12:18
This was referenced Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants