Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused ginkgo suites #3662

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jul 24, 2023

Description

  • Remove unused Ginkgo suites from
    • warehouse/integrations
    • services/multitenant

Notion Ticket

https://www.notion.so/rudderstacks/wh-backend-config-refactoring-d65c58fbc0054100b127b37706d04684?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr changed the title chore: remove ginkgo suites chore: remove unused ginkgo suites Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (1c94c53) 68.11% compared to head (73e82df) 68.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
+ Coverage   68.11%   68.19%   +0.08%     
==========================================
  Files         319      319              
  Lines       50445    50445              
==========================================
+ Hits        34359    34403      +44     
+ Misses      13861    13825      -36     
+ Partials     2225     2217       -8     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 merged commit 66a863a into master Jul 25, 2023
45 checks passed
@cisse21 cisse21 deleted the chore.remove-ginkgo-suites branch July 25, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants