chore: add custom buckets to gateway.user_suppression_age #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
approved these changes
Jul 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.x #3679 +/- ##
=================================================
Coverage ? 67.98%
=================================================
Files ? 318
Lines ? 50383
Branches ? 0
=================================================
Hits ? 34253
Misses ? 13898
Partials ? 2232 ☔ View full report in Codecov by Sentry. |
atzoum
reviewed
Jul 28, 2023
runner/buckets.go
Outdated
| @@ -4,4 +4,7 @@ var customBuckets = map[string][]float64{ | |||
| "gateway.response_time": { | |||
| 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10, 60, | |||
| }, | |||
| "gateway.user_suppression_age": { | |||
| 86400, 2592000, 5184000, 7776000, // 1 day, 1 month, 2 months, 3 months | |||
There was a problem hiding this comment.
Why not some more buckets, e.g.
1d, 5d, 10d, 30d, 60d 90d 180d, 360d
There was a problem hiding this comment.
Made the buckets as
1d, 5d, 10d, 30d, 60d 90d 180d, 360d
cc @lvrach
BonapartePC
force-pushed
the
chore.customBuckets1
branch
from
25ddde1
to
00e1403
Compare
atzoum
approved these changes
Jul 28, 2023
Merged
1 task
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add custom buckets i.e. 1 day, 5 days, 10 days, 30 days, 60 days, 90 days, 180 days, 360 days for gateway.user_suppression_age metric
Notion Ticket
https://www.notion.so/rudderstacks/Add-custom-buckets-1-day-5-days-10-days-30-days-60-days-90-days-180-days-360-days-for-gateway-6fc3093d32834f6a9ee3576964f81a81
Security