Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send last error response for aborted jobs to reporting #3692

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Aug 2, 2023

Description

This PR sends the last error response to reporting and in the job status table for the jobs which get aborted due the exhausting their retries

Linear Ticket

Linear Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25% 🎉

Comparison is base (1cdc6d1) 68.10% compared to head (8ffdab7) 68.35%.
Report is 1 commits behind head on master.

❗ Current head 8ffdab7 differs from pull request most recent head 3b9f30e. Consider uploading reports for the commit 3b9f30e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
+ Coverage   68.10%   68.35%   +0.25%     
==========================================
  Files         319      319              
  Lines       50446    50448       +2     
==========================================
+ Hits        34357    34485     +128     
+ Misses      13863    13741     -122     
+ Partials     2226     2222       -4     
Files Changed Coverage Δ
router/worker.go 82.40% <100.00%> (+0.04%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

router/worker.go Outdated Show resolved Hide resolved
router/worker.go Outdated Show resolved Hide resolved
router/worker.go Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the chore.sendLastErrorResponse branch from 8ffdab7 to a5d8920 Compare August 2, 2023 11:11
@cisse21 cisse21 requested a review from atzoum August 2, 2023 11:20
Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
@cisse21 cisse21 force-pushed the chore.sendLastErrorResponse branch from 8408735 to 3b9f30e Compare August 2, 2023 11:35
@cisse21 cisse21 merged commit cfbeee9 into master Aug 2, 2023
33 checks passed
@cisse21 cisse21 deleted the chore.sendLastErrorResponse branch August 2, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants