Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase transformer request timeouts #3701

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Aug 3, 2023

Description

There are multiple occasions where we currently need a much higher timeout than 30s during transformation requests, e.g. when using large event batches and transformer needs to perform some external request(s). This has also caused a number of issues already, forcing us to manually increase this timeout. Therefore increasing the default timeout to 10 minutes, instead of 30 seconds.

Linear Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.35% 🎉

Comparison is base (3cca234) 68.05% compared to head (189c8ef) 68.41%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3701      +/-   ##
==========================================
+ Coverage   68.05%   68.41%   +0.35%     
==========================================
  Files         319      319              
  Lines       50456    50456              
==========================================
+ Hits        34339    34520     +181     
+ Misses      13890    13709     -181     
  Partials     2227     2227              
Files Changed Coverage Δ
router/handle.go 72.48% <ø> (+0.65%) ⬆️
router/worker.go 82.38% <0.00%> (ø)
processor/transformer/transformer.go 90.25% <100.00%> (ø)
router/handle_lifecycle.go 95.34% <100.00%> (+0.99%) ⬆️
router/transformer/transformer.go 69.56% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 merged commit 998ce44 into master Aug 3, 2023
39 of 40 checks passed
@cisse21 cisse21 deleted the chore.transformerTimeout branch August 3, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants