Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse replay configuration from backend config #3703

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Aug 4, 2023

Description

Reading event replay configurations from backend config and mapping them to sources with destinations of a special replay type & category.

Linear Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum changed the title [WIP] feat: support replay configuration from backend config [WIP] feat: parse replay configuration from backend config Aug 6, 2023
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (c948122) 68.09% compared to head (75bb25a) 68.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3703      +/-   ##
==========================================
+ Coverage   68.09%   68.11%   +0.01%     
==========================================
  Files         333      334       +1     
  Lines       51454    51510      +56     
==========================================
+ Hits        35038    35086      +48     
- Misses      14133    14138       +5     
- Partials     2283     2286       +3     
Files Changed Coverage Δ
backend-config/namespace_config.go 73.28% <100.00%> (+0.62%) ⬆️
backend-config/replay_types.go 100.00% <100.00%> (ø)
backend-config/single_workspace.go 80.00% <100.00%> (+0.17%) ⬆️
backend-config/types.go 82.50% <100.00%> (+8.42%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum changed the title [WIP] feat: parse replay configuration from backend config feat: parse replay configuration from backend config Aug 7, 2023
@atzoum atzoum requested a review from achettyiitr August 7, 2023 08:01
backend-config/types.go Outdated Show resolved Hide resolved
backend-config/replay_types.go Outdated Show resolved Hide resolved
@atzoum atzoum force-pushed the feat.eventReplayConfig branch 2 times, most recently from 2de68d6 to 780da06 Compare August 9, 2023 10:58
@atzoum atzoum merged commit 35f55e0 into master Aug 10, 2023
35 checks passed
@atzoum atzoum deleted the feat.eventReplayConfig branch August 10, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants