-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: gateway #3708
refactor: gateway #3708
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3708 +/- ##
==========================================
+ Coverage 68.17% 68.29% +0.11%
==========================================
Files 320 324 +4
Lines 50469 50437 -32
==========================================
+ Hits 34409 34446 +37
+ Misses 13836 13765 -71
- Partials 2224 2226 +2
☔ View full report in Codecov by Sentry. |
7eeacde
to
a493f43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments are irrelevant for this PR since large portions of code moved and this is preparatory PR.
12ebf81
to
bf88c80
Compare
bf88c80
to
26499ca
Compare
tried to address them nevertheless :) |
Description
Doing some preliminary work for being able to perform another refactoring that is going to modify gateway's functions to start relying on sourceID rather than writeKey:
gateway.Handle
gateway.Handle
fields into logical groupsgateway#Setup
to fill in necessary configuration moved from global configurationgateway.go
into more files containing logically grouped gateway functionalitiesLinear Ticket
Link
Security