Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: addressing review coments from #3602 #3713

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 7, 2023

Description

Linear Ticket

https://www.notion.so/rudderstacks/wh-backend-config-d65c58fbc0054100b127b37706d04684

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.10% 🎉

Comparison is base (e48c98e) 68.17% compared to head (fbbc869) 68.28%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
+ Coverage   68.17%   68.28%   +0.10%     
==========================================
  Files         320      320              
  Lines       50469    50469              
==========================================
+ Hits        34409    34461      +52     
+ Misses      13832    13779      -53     
- Partials     2228     2229       +1     
Files Changed Coverage Δ
warehouse/backend_config.go 86.02% <66.66%> (-0.32%) ⬇️
warehouse/warehouse.go 64.02% <100.00%> (-0.04%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

warehouse/warehouse.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr merged commit 141d109 into master Aug 8, 2023
35 checks passed
@fracasula fracasula deleted the chore.whBackendConfig+review-comments branch August 8, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants