Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce source category for deduplication #3730

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 10, 2023

Description

  • We want this to filter and group dedup_rows based on source category as well. Especially extract sources because they use a different deduplication strategy based on recordID.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (5a36137) 68.09% compared to head (a49f346) 68.11%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3730      +/-   ##
==========================================
+ Coverage   68.09%   68.11%   +0.01%     
==========================================
  Files         333      333              
  Lines       51462    51460       -2     
==========================================
+ Hits        35042    35050       +8     
+ Misses      14134    14127       -7     
+ Partials     2286     2283       -3     
Files Changed Coverage Δ
warehouse/integrations/deltalake/deltalake.go 74.28% <100.00%> (+0.05%) ⬆️
warehouse/integrations/postgres/load.go 90.63% <100.00%> (+0.01%) ⬆️
warehouse/integrations/redshift/redshift.go 66.81% <100.00%> (+0.02%) ⬆️
warehouse/integrations/snowflake/snowflake.go 64.93% <100.00%> (+0.06%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula merged commit 00f994b into master Aug 10, 2023
43 of 44 checks passed
@fracasula fracasula deleted the chore.dedup-rows-source-cactegory branch August 10, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants