Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for logging duplicate messageIDs #3759

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

achettyiitr
Copy link
Member

Description

  • Added support for logging duplicate message Ids for an upload for Snowflake.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr
Copy link
Member Author

Tried the queries for the 30 days interval for mattermost and it looks good.

Screenshot 2023-08-17 at 3 49 49 PM Screenshot 2023-08-17 at 3 51 53 PM

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 13.25% and project coverage change: -0.17% ⚠️

Comparison is base (94df125) 69.10% compared to head (000dec6) 68.93%.

❗ Current head 000dec6 differs from pull request most recent head df1f383. Consider uploading reports for the commit df1f383 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
- Coverage   69.10%   68.93%   -0.17%     
==========================================
  Files         347      348       +1     
  Lines       51753    51834      +81     
==========================================
- Hits        35762    35730      -32     
- Misses      13692    13802     +110     
- Partials     2299     2302       +3     
Files Changed Coverage Δ
warehouse/integrations/snowflake/snowflake.go 60.37% <4.00%> (-4.13%) ⬇️
warehouse/upload.go 71.52% <100.00%> (+0.03%) ⬆️
warehouse/utils/context.go 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the chore.snowflake-log-duplicate-records branch from 9c73adc to 5e2fc05 Compare August 18, 2023 05:35
@achettyiitr achettyiitr force-pushed the chore.snowflake-log-duplicate-records branch from 5e2fc05 to db13ffb Compare August 18, 2023 05:39
@achettyiitr achettyiitr force-pushed the chore.snowflake-log-duplicate-records branch from db13ffb to 6abcc5a Compare August 18, 2023 06:47
warehouse/integrations/snowflake/snowflake.go Outdated Show resolved Hide resolved
warehouse/utils/context.go Outdated Show resolved Hide resolved
warehouse/utils/context.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr force-pushed the chore.snowflake-log-duplicate-records branch from 313634b to 000dec6 Compare August 28, 2023 07:01
@achettyiitr achettyiitr force-pushed the chore.snowflake-log-duplicate-records branch from 000dec6 to df1f383 Compare August 28, 2023 07:17
@achettyiitr achettyiitr merged commit 890ccb6 into master Aug 28, 2023
33 checks passed
@achettyiitr achettyiitr deleted the chore.snowflake-log-duplicate-records branch August 28, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants